BUG:don't start divx from cd with char special chars

everything about the previous stable version

Moderator: Moderator

User avatar
castorinop
veteran
Posts: 331
Joined: Wed Jun 07, 2006 6:34 pm
Location: Argentina
Contact:

BUG:don't start divx from cd with char special chars

Postby castorinop » Sat Feb 17, 2007 8:48 pm

the cd content: "Pablito's Party.avi" and the output for mplayer is..

Code: Select all

Playing /mnt/dvd/Pablitos Party.avi /mnt/dvd/Pablito.
File not found: '/mnt/dvd/Pablitos Party.avi /mnt/dvd/Pablito'
Failed to open /mnt/dvd/Pablitos Party.avi /mnt/dvd/Pablito.


Pablito

User avatar
castorinop
veteran
Posts: 331
Joined: Wed Jun 07, 2006 6:34 pm
Location: Argentina
Contact:

Postby castorinop » Sun Feb 18, 2007 2:15 pm

the patch.. :D

Code: Select all

--- ../baz-mms-1.0.9/movie.cpp  2007-02-15 19:14:19.000000000 -0300
+++ movie.cpp   2007-02-18 11:13:48.000000000 -0300
@@ -1602,8 +1658,8 @@
     file_types = file_types.substr(0, file_types.size()-4);
 
     string play_cmd = "find " + cd->get_mount_point() +
-      " -follow -maxdepth 8 -type f -printf \"'%p' \" " +
-      file_types + " | xargs " + player_cmd;
+      " -follow -maxdepth 8 -type f -print0 " +
+      file_types + " | xargs -0 " + player_cmd;
 
     run::my_system(play_cmd.c_str());
 


Pablito

User avatar
acmelabs
Overlord
Posts: 2365
Joined: Mon Feb 20, 2006 9:18 pm
Location: Germany
Contact:

Postby acmelabs » Sun Feb 18, 2007 9:00 pm

castorinop wrote:the patch.. :D

Code: Select all

--- ../baz-mms-1.0.9/movie.cpp  2007-02-15 19:14:19.000000000 -0300
+++ movie.cpp   2007-02-18 11:13:48.000000000 -0300
@@ -1602,8 +1658,8 @@
     file_types = file_types.substr(0, file_types.size()-4);
 
     string play_cmd = "find " + cd->get_mount_point() +
-      " -follow -maxdepth 8 -type f -printf "'%p' " " +
-      file_types + " | xargs " + player_cmd;
+      " -follow -maxdepth 8 -type f -print0 " +
+      file_types + " | xargs -0 " + player_cmd;
 
     run::my_system(play_cmd.c_str());
 

Pablito


Hi Pablito,
thanks for the patch :-)
Does it mean, that I can't play AVIs without your patch?
Could you drop a few words about the problem, that you have already fixed?
Does Anders know about that? Should this patch go into main-line?
Thanks,

Regards,

Andreas

User avatar
arj
Site Admin
Posts: 2316
Joined: Thu Dec 01, 2005 8:51 pm
Location: Denmark
Contact:

Postby arj » Sun Feb 18, 2007 9:44 pm

Thanks. The patch looks good. Applied as patch-34.


Return to “1.0.8”

Who is online

Users browsing this forum: No registered users and 1 guest