CD-Ripping - Plugin

Discussion about user contributed plugins

Moderator: Moderator

User avatar
Uatschitchun
Overlord
Posts: 3189
Joined: Tue Dec 06, 2005 6:55 pm
Location: Germany
Contact:

Re: CD-Ripping - Plugin

Postby Uatschitchun » Tue Jan 13, 2009 8:37 pm

Nice progressing here ;)
Lg
Roman

User avatar
magicamun
master
Posts: 688
Joined: Thu Feb 28, 2008 7:42 am
Location: Germany

Re: CD-Ripping - Plugin

Postby magicamun » Tue Jan 13, 2009 9:38 pm

thanks for the feedback - i am almost done with the corrections/changes your mentioned in last post

i am not sure if the problem with the "-" is display only - will check.
EDIT : I am quite sure that it is with core - with CDTag respectively - what happens when you play this cd with audio-plugin - is it displayed correctly?

EDIT2: post the cddb-data-file - for that cddb-id - can be found in $HOME/.mms/cddb_data


I like your approach for touchable - second_action - let us propose this for 1.2.0

Regarding the first CD I tried which did not work, it was a music & data CD which failed to mount so no need for further investigation.


which version of mms (revno) are you using - there was a patch to mainline to be able to handle - hybrid - cd's

Mario
Posts: 26
Joined: Sat Nov 15, 2008 8:16 am

Re: CD-Ripping - Plugin

Postby Mario » Wed Jan 14, 2009 1:01 pm

Thx for taking my opinion into account.

Here is the gzipped cddb data. Everything is fine.

With the audio plugin, CD inspection works ok, and playback too. The generated playlist shows correct titles.

Edit: btw, the minus sign bug comes from this code:

Code: Select all

   cdpd->SetSampler(false);

   for (int i = 0; i < cdpd->NumberOfTracks() ; i++) {
        if (global->check_stop_bit()) {
                // audiolist_new.clear();
                break;
        }

        std::ostringstream _buf;

        if (_ret >0) {
                _buf << "TTITLE" << i;
                cdtag->GetEntryInfo(_ret-1, _buf.str().c_str(), &title);
        }

        int delim;

        delim = title.find(" - ");
        if (delim > 0) {
                artist = title.substr(0, delim);
                title = title.substr(delim + 3);
                cdpd->SetSampler(true);
        }
        cdpd->Track(i)->SetTitle(title);
        cdpd->Track(i)->SetArtist(artist);
    }


1- you should reset artist to former value, or use a local variable.
2- the - in the title might not indicate a "Sampler" CD
3- who cares since it doesn't affect the id3tags or filename :D ?

HTH
Attachments
930c070a.gz
(470 Bytes) Downloaded 78 times

User avatar
magicamun
master
Posts: 688
Joined: Thu Feb 28, 2008 7:42 am
Location: Germany

Re: CD-Ripping - Plugin

Postby magicamun » Wed Jan 14, 2009 9:23 pm

i don't know what made me do this bullshit thx for finding.

here is the new bundle:

EDIT : Link removed

it fixes/changes:
- rip-plugin now has touch-support for selecting/deselcting tracks, back to main menu and start ripping
- the plugin auto-selects all the tracks once a cd is read
- the plugin provides a touch - area on the cover - which will start the ripping
- in the upper left corner there is a "back" - area for touch-input - as with the other plugins
- Cursor-position is remembered and cursor is moved when ripping
- refreshing is on 0.5 seconds only when ripping is active
- fixed the dash-issue - thx for pointing me to it.


it fixes/changes NOT:
- second.menu-action in upper right corner for touch - even though i think it would be a good idea and will back that idea for 1.2
- no further threading for postprocessing yet (not decided if i will do)
- no notify-support currently ( meaning i have not done anything on a global progress-info)

have fun

User avatar
magicamun
master
Posts: 688
Joined: Thu Feb 28, 2008 7:42 am
Location: Germany

Re: CD-Ripping - Plugin

Postby magicamun » Sun Jan 18, 2009 7:32 pm

New Bundle:

This contains
- a bugfix (Last track did not return)
- removed cursor-movement on ripping (that caused the bug)
- added support for notify-area

http://thielemann-net.de/mms/rip/rip5.bzr.gz

User avatar
arj
Site Admin
Posts: 2316
Joined: Thu Dec 01, 2005 8:51 pm
Location: Denmark
Contact:

Re: CD-Ripping - Plugin

Postby arj » Mon Jan 19, 2009 8:41 am

Hi magicanum

Is it possible you can provide a simple tar.gz since I can't seem to apply your bundle?

Thanks

User avatar
magicamun
master
Posts: 688
Joined: Thu Feb 28, 2008 7:42 am
Location: Germany

Re: CD-Ripping - Plugin

Postby magicamun » Mon Jan 19, 2009 10:29 am

sure - wednesday evening - i am on business - trip

User avatar
Uatschitchun
Overlord
Posts: 3189
Joined: Tue Dec 06, 2005 6:55 pm
Location: Germany
Contact:

Re: CD-Ripping - Plugin

Postby Uatschitchun » Mon Jan 19, 2009 12:23 pm

Bundle applies nicely here!
Lg

Roman

User avatar
magicamun
master
Posts: 688
Joined: Thu Feb 28, 2008 7:42 am
Location: Germany

Re: CD-Ripping - Plugin

Postby magicamun » Mon Jan 19, 2009 12:46 pm

thx roman - at mine too - at least before i posted it.

User avatar
Uatschitchun
Overlord
Posts: 3189
Joined: Tue Dec 06, 2005 6:55 pm
Location: Germany
Contact:

Re: CD-Ripping - Plugin

Postby Uatschitchun » Tue Jan 20, 2009 8:38 am

In notify-area, there should be no infos displayed, if no cd is beeing ripped!

I do get
Notify-ripping
Notify-ripping
Notify-ripping

only because rip-plugin is installed ;(

In my eyes, n-a only should get infos, if there are infos ;)
Lg

Roman

User avatar
magicamun
master
Posts: 688
Joined: Thu Feb 28, 2008 7:42 am
Location: Germany

Re: CD-Ripping - Plugin

Postby magicamun » Tue Jan 20, 2009 9:05 am

thats debug - sorry - will remove

btw: Roman i am sorry that i captured your revno.

User avatar
arj
Site Admin
Posts: 2316
Joined: Thu Dec 01, 2005 8:51 pm
Location: Denmark
Contact:

Re: CD-Ripping - Plugin

Postby arj » Tue Jan 20, 2009 10:46 am

Roman, could you create a tarball for me to test? :D

User avatar
magicamun
master
Posts: 688
Joined: Thu Feb 28, 2008 7:42 am
Location: Germany

Re: CD-Ripping - Plugin

Postby magicamun » Tue Jan 20, 2009 1:20 pm

you will receive mail on your account at gnulinux

User avatar
arj
Site Admin
Posts: 2316
Joined: Thu Dec 01, 2005 8:51 pm
Location: Denmark
Contact:

Re: CD-Ripping - Plugin

Postby arj » Wed Jan 21, 2009 9:32 pm

Thanks!

Small review:

- the text for Cannot read cd is placed at a strange place. It's not centered either in the middle or to the left. That looks a bit wierd.
- execute_after_track = /usr/lib/mms/mms-rip-posttrack.sh => maybe use by default <MMS_INSTALL_DIR>/mms-rip-posttrack.sh and check if the first char is a /, in that case threat it as a full path.
- would be very nice if I changed .wav to .flac that it figure out that I wanted to rip in flac and had to do nothing more. Same with ogg and mp3.
- destination_folder = /music/lt, maybe leave that undefined and by default use the audio dir?
- no check for empty disc (permission problems)

User avatar
magicamun
master
Posts: 688
Joined: Thu Feb 28, 2008 7:42 am
Location: Germany

Re: CD-Ripping - Plugin

Postby magicamun » Thu Jan 22, 2009 9:16 am

arj wrote:Thanks!


welcome

Small review:

- the text for Cannot read cd is placed at a strange place. It's not centered either in the middle or to the left. That looks a bit wierd.


will check / change

- execute_after_track = /usr/lib/mms/mms-rip-posttrack.sh => maybe use by default <MMS_INSTALL_DIR>/mms-rip-posttrack.sh and check if the first char is a /, in that case threat it as a full path.


good idea

- would be very nice if I changed .wav to .flac that it figure out that I wanted to rip in flac and had to do nothing more. Same with ogg and mp3.


as discussed at irc - i will change the script and the arguments

- destination_folder = /music/lt, maybe leave that undefined and by default use the audio dir?

which audio - dir - there may be more than just one... - i change the default to /music

- no check for empty disc (permission problems)

i will fix that


Return to “user plugins”

Who is online

Users browsing this forum: No registered users and 1 guest